[loki] Add cooldownPeriod to defaults.kedaAutoscaling#322
Merged
Conversation
jkroepke
reviewed
Apr 10, 2026
QuentinBisson
force-pushed
the
fix/keda-cooldown-global-default
branch
from
d3e55da to
a0e2148
Compare
QuentinBisson
commented
Apr 11, 2026
QuentinBisson
force-pushed
the
fix/keda-cooldown-global-default
branch
2 times, most recently
from
29c5288 to
eca9bd7
Compare
cooldownPeriod was not included in defaults.kedaAutoscaling, meaning it could not be overridden globally like pollingInterval. Add it with the same default of 300s and use coalesce in _keda.tpl so users can set a single value in defaults.kedaAutoscaling.cooldownPeriod to apply across all components instead of overriding each component individually. Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
* [loki] Add template helper for single-binary Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * [loki] Add template helper for single-binary Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * revert container rename Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * add UI target Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * add UI target Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * add UI target Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Co-authored-by: Quentin Bisson <quentin.bisson@gmail.com> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
…n is disabled. (#326) Signed-off-by: Justin Bronn <justin.bronn@vantor.com> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
* [tempo-distributed] add support for seprate cache per role Signed-off-by: AvivGuiser <avivguiser@gmail.com> * [tempo-distributed] add metrics port, update README and more tests Signed-off-by: AvivGuiser <avivguiser@gmail.com> * [tempo-distributed] add exporter sidecar and annotations to sts Signed-off-by: AvivGuiser <avivguiser@gmail.com> --------- Signed-off-by: AvivGuiser <avivguiser@gmail.com> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
#327) * [tempo-distributed] Auto-inject GOMEMLIMIT from container memory limit Automatically inject the GOMEMLIMIT environment variable for all Tempo Go components when a container memory limit is configured and GOMEMLIMIT is not already set by the user. Also injects GOGC=80 by default. Mirrors the approach from the loki chart (PR #230). Signed-off-by: drfaust92 <Ilia.lazebnik@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * Update Chart.yaml Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <Ilia.lazebnik@gmail.com> Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> Signed-off-by: Ilia Lazebnik <Ilia.lazebnik@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Sheikh-Abubaker <sheikhabubaker761@gmail.com> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
* [CI] Update actions/create-github-app-token action to v3.1.0 * fix linter Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * fix linter Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * fix linter Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> * fix linter Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> --------- Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jan-Otto Kröpke <mail@jkroepke.de> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com> Signed-off-by: QuentinBisson <quentin@giantswarm.io>
QuentinBisson
force-pushed
the
fix/keda-cooldown-global-default
branch
from
eca9bd7 to
1b92ed3
Compare
QuentinBisson
requested review from
a team,
DrFaust92 and
Sheikh-Abubaker
as code owners
Signed-off-by: Quentin Bisson <quentin.bisson@gmail.com>
jkroepke
approved these changes
Apr 11, 2026
QuentinBisson
added a commit
that referenced
this pull request
Apr 12, 2026
Signed-off-by: QuentinBisson <quentin@giantswarm.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
cooldownPeriodto the shareddefaults.kedaAutoscalingblock and usecoalescein_keda.tpl, consistent with howpollingIntervalalready works.Why
pollingIntervalcan be set once indefaults.kedaAutoscaling.pollingIntervalto apply globally across all KEDA-enabled components.cooldownPerioddid not have this — it was hardcoded at 300s per component with no way to override globally. A user wanting to change the cooldown period had to repeat the override for every component individually.Change
values.yaml— add todefaults.kedaAutoscaling:_keda.tpl— use coalesce to fall back to the shared default:No behaviour change for existing deployments — per-component defaults remain 300s and take precedence over the shared default.
Signed-off-by: Quentin Bisson quentin.bisson@gmail.com